COUNTER_Robots_list.json: Remove anchors from okhttp #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanorth
added a commit
to ilri/DSpace
that referenced
this pull request
Apr 30, 2020
Import some of the spider agent patterns that I had submitted to the COUNTER-Robots project a few months ago that are still pending merges: - atmire/COUNTER-Robots#33 - atmire/COUNTER-Robots#34
alanorth
added a commit
to ilri/DSpace
that referenced
this pull request
Apr 30, 2020
Import some of the spider agent patterns that I had submitted to the COUNTER-Robots project a few months ago that are still pending merges: - atmire/COUNTER-Robots#33 - atmire/COUNTER-Robots#34
The okhttp library now uses version strings in its user agent so we
should not anchor the string with ^ and $. For example, I have seen
both of these recently:
okhttp/3.11.0
okhttp/3.10.0
We could add a "/\d" to match the version string, but I think that
the "okhttp" is unique enough by itself to not be confused with a
real human user agent.
|
Rebased against latest mаster branch. |
alanorth
added a commit
to ilri/DSpace
that referenced
this pull request
Jul 20, 2020
These are waiting to be merged into the COUNTER-Robots project: - New bots: https://github.com/atmire/COUNTER-Robots/pulls - Escape literal dots: atmire/COUNTER-Robots#35 - Remove okhttp anchors: atmire/COUNTER-Robots#33
alanorth
added a commit
to ilri/DSpace
that referenced
this pull request
Jul 20, 2020
These are waiting to be merged into the COUNTER-Robots project: - New bots: https://github.com/atmire/COUNTER-Robots/pulls - Escape literal dots: atmire/COUNTER-Robots#35 - Remove okhttp anchors: atmire/COUNTER-Robots#33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The okhttp library now uses version strings in its user agent so we should not anchor the string with ^ and $. For example, I have seen both of these recently:
We could add a
/\dto match the version string, but I think that the "okhttp" is unique enough by itself to not be confused with a real human user agent.See #9